Implement QosProvider for C++ API. #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
reviewed
Apr 4, 2024
src/ddscxx/src/org/eclipse/cyclonedds/domain/qos/DomainParticipantQosDelegate.cpp
Show resolved
Hide resolved
e-hndrks
force-pushed
the
master_erik
branch
4 times, most recently
from
31e744b
to
bd456c4
Compare
eboasson
reviewed
Apr 9, 2024
.azure/templates/build-test.yml
Outdated
| @@ -118,6 +118,7 @@ steps: | |||
| cmake -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \ | |||
| -DCMAKE_INSTALL_PREFIX=install \ | |||
| -DCMAKE_PREFIX_PATH="${BUILD_SOURCESDIRECTORY}/cyclonedds/build/install;${BUILD_SOURCESDIRECTORY}/iceoryx/build/install;${BUILD_SOURCESDIRECTORY}/googletest/build/install" \ | |||
| -DCYCLONE_SOURCE_DIR="${BUILD_SOURCESDIRECTORY}/cyclonedds" \ | |||
There was a problem hiding this comment.
I suspect this is needed for including dds__sysdef_model.h in the test code, but it is really inelegant to require the C sources to be present to build the C++ binding — we never had that tight a relationship, and I don't think the QoS provider should change that.
Now, I haven't made an effort yet to find out which bits exactly are needed but it appears likely that only a fraction of what is in that file is needed. Before merging it like this, I'd like to know whether the bits that are needed can reasonably be installed by the core library. That would eliminate the need for this hack.
(Apologies for not spotting this earlier.)
e-hndrks
force-pushed
the
master_erik
branch
2 times, most recently
from
dbabaec
to
58ccd26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QosProvider functionality to C++ in accordance with the work done for eclipse-cyclonedds/cyclonedds#1955.